]> dgit.raspbian.org Git - gnome-shell.git/commit
Remove broken ShellAppSystem API and all consumers
authorColin Walters <walters@verbum.org>
Thu, 10 Mar 2011 17:19:10 +0000 (12:19 -0500)
committerColin Walters <walters@verbum.org>
Wed, 16 Mar 2011 19:07:22 +0000 (15:07 -0400)
commitfea8b6da2fd524bbdade67516c2d107eda3cf1f0
treeab7c71efaf98d1b09aad0b41c768663e5bf43ccc
parent4bf1df0894f8508d7a9476f7d432534b28930d98
Remove broken ShellAppSystem API and all consumers

In commit 9bd22dc0, I introduced an API to load an arbitrary
.desktop file, not necessarily from the menu path.  It turns
out this function was broken because it created ShellApp instances
that were *different* from ones that were cached normally.

As far as I can tell, we didn't initially use it.  Then later
Util.spawnDesktop was created which used this function.

Remove this broken function and all callers; if we're loading
.desktop files from *outside* the menu path, we can look at
readding.

This patch also kills off Util.spawnDesktop in favor of callers
talking to ShellAppSystem directly, now that the latter reports
errors.

https://bugzilla.gnome.org/show_bug.cgi?id=644402
js/misc/util.js
js/ui/dateMenu.js
js/ui/status/accessibility.js
js/ui/status/power.js
js/ui/status/volume.js
js/ui/statusMenu.js
src/shell-app-system.c
src/shell-app-system.h